Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excel Import & Export Feature #49

Open
wants to merge 41 commits into
base: master
Choose a base branch
from

Conversation

mustafaaloko
Copy link

@mustafaaloko mustafaaloko commented Aug 11, 2016

As of feature request: #31.

This PR implements the import/export feature of language files from/to Excel. Uses PHPExcel to read and write files.

Run php artisan help langman:export on how to use Export command.

By default exported files will be written to the storage/langman-exports directory. Although using --path you will be able to change the path relative to base path.

Run php artisan help langman:import on how to use Import command.

By default it accepts the name of Excel file inside storage/langman-exports directory as argument. You can assign a custom path using --path relative to base path.

Once approved, will update the docs.

@mustafaaloko
Copy link
Author

Style fixes are complete. @themsaid you will squash the commits while merging or I should do it now?

@mustafaaloko
Copy link
Author

@themsaid You still haven't took a look into this PR, is it that you couldn't got time or this PR has problems. If you are busy then it's fine, I am waiting, but if there is a problem with this PR, please let me know so I can make fixes.

@@ -26,7 +26,7 @@ public function tearDown()
{
parent::tearDown();

exec('rm -rf '.__DIR__.'/temp/*');
// exec('rm -rf '.__DIR__.'/temp/*');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why commenting this line?

@themsaid
Copy link
Owner

@mustafaaloko thank you for your efforts :)
I was just holding all my Open Source changes until 5.3 is released, now I'm putting my mind into it :)

@themsaid
Copy link
Owner

I can't find any tests for the addition, it's hard for me to check on it. Can you please add tests?

@mustafaaloko
Copy link
Author

@themsaid Added tests for both import and export commands, and for changes in Manager class. Also brought some other changes you asked for. Check and let me know. Thanks!

@tpraxl
Copy link

tpraxl commented Sep 16, 2016

I would very much appreciate this feature. @themsaid can you tell us if you're currently working on this PR? Is there anything I could do in order to help? Any issues that need fixing?

@mustafaaloko
Copy link
Author

Ping @themsaid.

@hamedmehryar
Copy link

I can't help waiting for this feature to be added. Can you Plz tell when will be this merged?

@mustafaaloko
Copy link
Author

@themsaid any updates on this? please let me know if this is not going to be merged. Please let me know of the reasons as well so I would know if there were any problems from my side.

@mbardelmeijer
Copy link
Contributor

Would be great if this could be merged 😄

@Cyrille37
Copy link

Hi all,
This work seems to be dead :(
Should I fork @mustafaaloko excel-import-export branch or is there another repository where this package is alive ?

Thanks & Cheers :-)

@Cyrille37
Copy link

I found this simple package laravel-lang-import-export for languages import/export which make the job for different Laravel's versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants